{rdbms-connect} Add support to read UTF-8 files with and without BOM#5162
Merged
evelyn-ys merged 1 commit intoAzure:mainfrom Aug 2, 2022
Merged
Conversation
Collaborator
|
rdbms-connect |
evelyn-ys
approved these changes
Aug 2, 2022
Member
|
If you want to release a new version, please update |
alanenriqueo
force-pushed
the
rdbms-connect/fix-utf8-bom-execute
branch
from
b639e1e to
ee6c9a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a sql file with UTF-8 BOM encoding is passed to the command
az postgres flexible-server executeit will fail because its contents are read assuming that the encoding isutf-8. We need to change toutf-8-sigto be able to handle both cases (UTF-8 with/without BOM).This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify
src/index.json.